Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add missing protobuf definitions (#8600)" #8710

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

PaddyMc
Copy link
Collaborator

@PaddyMc PaddyMc commented Sep 17, 2024

What is the purpose of the change

Ci is broken because of this PR, because after proto generation this commit break build

This reverts commit ba5ecb1.

@PaddyMc PaddyMc added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label Sep 17, 2024
Copy link
Contributor

coderabbitai bot commented Sep 17, 2024

Walkthrough

The pull request primarily involves the removal of unused protobuf message definitions from various .proto files within the Osmosis protocol. Specifically, messages related to pool creation and token unlocking have been eliminated, while retaining comments for historical indexing. Additionally, the changelog has been updated to reflect these changes and remove references to a previously documented bug fix.

Changes

File Path Change Summary
proto/osmosis/gamm/v1beta1/tx.proto Removed MsgCreatePool and MsgCreateBalancerPool message definitions, retaining comments for indexing.
proto/osmosis/lockup/tx.proto Removed MsgUnlockPeriodLock and MsgUnlockTokens message definitions, retaining comments for indexing.
proto/osmosis/protorev/v1beta1/tx.proto Removed MsgSetPoolWeights message definition, retaining comments for indexing.
CHANGELOG.md Updated to remove a section on a bug fix and now only includes a note about a chore related to cosmwasm-optimizer.

Possibly related PRs

Suggested labels

V:state/breaking, C:x/tokenfactory, C:x/concentrated-liquidity


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6caab9e and d32df87.

Files selected for processing (4)
  • CHANGELOG.md (0 hunks)
  • proto/osmosis/gamm/v1beta1/tx.proto (0 hunks)
  • proto/osmosis/lockup/tx.proto (1 hunks)
  • proto/osmosis/protorev/v1beta1/tx.proto (1 hunks)
Files not reviewed due to no reviewable changes (2)
  • CHANGELOG.md
  • proto/osmosis/gamm/v1beta1/tx.proto
Files skipped from review due to trivial changes (1)
  • proto/osmosis/lockup/tx.proto
Additional comments not posted (1)
proto/osmosis/protorev/v1beta1/tx.proto (1)

Line range hint 1-177: Removal of MsgSetPoolWeights message definition is approved.

Considering the context provided in the PR objectives, the removal of the MsgSetPoolWeights message definition is a necessary step to revert the changes that caused the CI build to break. This reversion will help restore the functionality of the CI process.

The removal suggests a shift in the protocol's handling of pool weights and potentially indicates a change in functionality or a simplification of the message types used in transactions. However, given the primary goal of fixing the broken CI build, this change is justified.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mattverse mattverse merged commit 8422244 into main Sep 17, 2024
1 check passed
@mattverse mattverse deleted the chore/revert-broken-protos branch September 17, 2024 18:36
@coderabbitai coderabbitai bot mentioned this pull request Oct 5, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants