Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inc flush-throttle-timeout overwrite to 80ms #8329

Merged
merged 3 commits into from
May 30, 2024
Merged

fix: inc flush-throttle-timeout overwrite to 80ms #8329

merged 3 commits into from
May 30, 2024

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented May 30, 2024 •
edited
Loading

Closes: #XXX

What is the purpose of the change

10ms was causing some validators to have issues, so we are increasing the default overwrite from 10ms to 80ms.

@czarcas7ic czarcas7ic added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v25.x backport patches to v25.x branch labels May 30, 2024
@czarcas7ic czarcas7ic marked this pull request as ready for review May 30, 2024 06:00
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 30, 2024 •
edited
Loading

Walkthrough

In version v25.0.3, the primary change involves updating the flush_throttle_timeout configuration from 10ms to 80ms. This adjustment impacts the timing behavior within the system, specifically in the P2P settings, to enhance performance and stability. No public or exported entities were altered.

Changes

File Change Summary
CHANGELOG.md Documented the update of flush_throttle_timeout to 80ms.
cmd/osmosisd/cmd/root.go Modified flush_throttle_timeout value from 10ms to 80ms.

Poem

In the code where packets flow,
Throttles now with time to grow,
Eighty milliseconds, a gentle breeze,
Bringing stability with ease.
A tweak so small, yet impacts grand,
In the network's careful hand.
Cheers to changes, swift and bright,
Making systems run just right! 🌟🐇

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between d2c4a96 and 9fa711c.
Files selected for processing (2)
  • CHANGELOG.md (2 hunks)
  • cmd/osmosisd/cmd/root.go (1 hunks)
Files skipped from review due to trivial changes (1)
  • cmd/osmosisd/cmd/root.go
Additional Context Used
Markdownlint (9)
CHANGELOG.md (9)

1070: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time

1082: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time

1091: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time

1096: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time

1148: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time

409: Punctuation: '.'
Trailing punctuation in heading

672: null
Bare URL used

730: null
Bare URL used

1311: null
No empty links

Additional comments not posted (2)
CHANGELOG.md (2)

54-54: Correct the version number format for consistency.

-## v25.0.3
+## [v25.0.3]

Likely invalid or redundant comment.

54-55: Ensure the change log entry for PR #8329 is categorized correctly.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@czarcas7ic czarcas7ic changed the title fix: inc flush-throttle-timeout to 80ms fix: inc flush-throttle-timeout overwrite to 80ms May 30, 2024
coderabbitai[bot]
coderabbitai bot reviewed May 30, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

CHANGELOG.md
Comment on lines +54 to +55
* [#8329](https://github.com/osmosis-labs/osmosis/pull/8329) Overwrite `flush_throttle_timeout` to 80ms instead of 10ms

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify the description for the change in flush_throttle_timeout.

-* [#8329](https://github.com/osmosis-labs/osmosis/pull/8329) Overwrite `flush_throttle_timeout` to 80ms instead of 10ms
+* [#8329](https://github.com/osmosis-labs/osmosis/pull/8329) Increase `flush_throttle_timeout` from 10ms to 80ms to resolve validator issues.
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
* [#8329](https://github.com/osmosis-labs/osmosis/pull/8329) Overwrite `flush_throttle_timeout` to 80ms instead of 10ms
* [#8329](https://github.com/osmosis-labs/osmosis/pull/8329) Increase `flush_throttle_timeout` from 10ms to 80ms to resolve validator issues.

@ValarDragon ValarDragon merged commit ab85212 into main May 30, 2024
1 check passed
@ValarDragon ValarDragon deleted the adam/revert-flush-throttle-timeout branch May 30, 2024 06:10
mergify bot pushed a commit that referenced this pull request May 30, 2024
@czarcas7ic @mergify
fix: inc flush-throttle-timeout overwrite to 80ms (#8329)
68af6a8 
* revert ftt

* set to 80ms

* add changelog

(cherry picked from commit ab85212)
@mergify mergify bot mentioned this pull request May 30, 2024
Merged
PaddyMc pushed a commit that referenced this pull request May 30, 2024
@mergify @czarcas7ic
fix: inc flush-throttle-timeout overwrite to 80ms (#8329) (#8330)
2a9df09 
* revert ftt

* set to 80ms

* add changelog

(cherry picked from commit ab85212)

Co-authored-by: Adam Tucker <adam@osmosis.team>
@coderabbitai coderabbitai bot mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
A:backport/v25.x backport patches to v25.x branch V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czarcas7ic @ValarDragon