Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: overwrite timeout propose from 3s to 2s #8226

Merged
merged 2 commits into from
May 6, 2024

Conversation

czarcas7ic
Copy link
Member

Closes: #XXX

What is the purpose of the change

Overwrites timeout propose from 3s to 2s.

@czarcas7ic czarcas7ic added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v25.x backport patches to v25.x branch labels May 6, 2024
@czarcas7ic czarcas7ic marked this pull request as ready for review May 6, 2024 03:36
Copy link
Contributor

coderabbitai bot commented May 6, 2024

Walkthrough

The recent update in the osmosis project reduces the timeoutPropose setting from 3 seconds to 2 seconds. This adjustment is aimed at optimizing the consensus mechanism by tweaking the timeout parameter to enhance system responsiveness and efficiency.

Changes

File Path Change Summary
cmd/osmosisd/cmd/root.go Added a new configuration setting timeout_propose with a value of "2s" under the consensus section.

🐇✨
In the land of code where the bits align,
A rabbit hopped in, making changes so fine.
From three to two, the seconds fell,
In consensus talks, less time will dwell.
Hop, hop, hop, on the silicon trails,
With every small tweak, the project sails!
🌟🐰


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (9)
CHANGELOG.md (9)

Line range hint 1024-1024: Correct the heading level from h4 to h3 for consistency.

- #### [v6.4.0]
+ ### [v6.4.0]

Line range hint 1036-1036: Correct the heading level from h4 to h3 for consistency.

- #### [v6.3.1]
+ ### [v6.3.1]

Line range hint 1045-1045: Correct the heading level from h4 to h3 for consistency.

- #### [v6.3.0]
+ ### [v6.3.0]

Line range hint 1050-1050: Correct the heading level from h4 to h3 for consistency.

- #### [v6.2.0]
+ ### [v6.2.0]

Line range hint 1102-1102: Correct the heading level from h4 to h3 for consistency.

- #### [v6.1.0]
+ ### [v6.1.0]

Line range hint 363-363: Remove the trailing punctuation in the heading.

- ## [v4.0.0]
+ ## [v4.0.0]

Line range hint 626-626: Replace the bare URL with a markdown link for better readability.

- See: [SDK v0.43.0 Release Notes](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.43.0) For more details
+ See: [SDK v0.43.0 Release Notes](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.43.0) for more details

Line range hint 684-684: Replace the bare URL with a markdown link for better readability.

- [wasmd-v.022.0-osmo-v7.2](https://github.com/osmosis-labs/wasmd/releases/tag/v0.22.0-osmo-v7.2) Upgrade SDK and IAVL dependencies to use fast storage
+ [wasmd-v.022.0-osmo-v7.2](https://github.com/osmosis-labs/wasmd/releases/tag/v0.22.0-osmo-v7.2) Upgrade SDK and IAVL dependencies to use fast storage

Line range hint 1265-1265: Ensure that there are no empty links in the document.

- [Link text]()
+ [Link text](#appropriate-link)

@czarcas7ic czarcas7ic merged commit 2edc21f into main May 6, 2024
1 check passed
@czarcas7ic czarcas7ic deleted the adam/overwrite-timeout-commit branch May 6, 2024 15:31
mergify bot pushed a commit that referenced this pull request May 6, 2024
czarcas7ic added a commit that referenced this pull request May 6, 2024
(cherry picked from commit 2edc21f)

Co-authored-by: Adam Tucker <adam@osmosis.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v25.x backport patches to v25.x branch V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants