Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sdk/iavl for async pruning #7994

Merged
merged 8 commits into from
Apr 9, 2024

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Apr 8, 2024

Closes: #XXX

What is the purpose of the change

We are noticing that some validators on IAVL v1 are missing blocks in the pruning interval, typically after epoch, due to larger blocks. This makes the pruning async, which should prevent these missed blocks from occurring.

Should be back ported to v23 IAVL v1 branch with tag v0.47.5-v23-osmo-9-iavl-v1

Testing and Verifying

Tested against osmosis mainet, and it unstuck a node that was pruning a large amount of blocks.

@czarcas7ic czarcas7ic added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v23.x backport patches to v23.x branch A:backport/v24.x backport patches to v24.x branch labels Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

@czarcas7ic czarcas7ic marked this pull request as ready for review April 8, 2024 23:23
Copy link
Contributor

coderabbitai bot commented Apr 8, 2024

Walkthrough

The Osmosis project has taken a significant leap forward with the introduction of asynchronous pruning for its Inter-Blockchain Communication (IBC) application-specific data structure, IAVL, in versions v24.0.1 and v23.0.12-iavl-v1. This enhancement aims to improve the efficiency and performance of the data structure, making the system more robust and scalable. Alongside, the update encompasses various fixes and updates to bolster the stability and functionality of earlier versions.

Changes

Files or File Patterns Change Summary
.../iavl/async_pruning.go Introduced async pruning feature for IAVL v1
.../iavl/... (various files) Minor fixes and updates in IAVL implementation
docs/, examples/, tests/ (various files) Updated documentation, examples, and tests

🐇✨
In the digital fields where data trees grow,
A leap of code, beneath the moon's soft glow.
Pruning away, async, without delay,
Making room for new, in a seamless ballet.
Osmosis flows, ever more swift and bright,
Guided by the rabbit's keen, watchful sight.
🌟🌿

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Collaborator

@PaddyMc PaddyMc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@czarcas7ic czarcas7ic merged commit 4b58243 into main Apr 9, 2024
1 check passed
@czarcas7ic czarcas7ic deleted the adam/bump-sdk-iavl-version-async-prune branch April 9, 2024 15:57
mergify bot pushed a commit that referenced this pull request Apr 9, 2024
* bump sdk/iavl for async pruning

* update changelog

* update osmoutils iavl

* bump gomods

* Revert "bump gomods"

This reverts commit 85c29d0.

* iavl

* update go mods

* fix version

(cherry picked from commit 4b58243)

# Conflicts:
#	CHANGELOG.md
#	go.mod
#	go.sum
#	osmomath/go.mod
#	osmomath/go.sum
#	osmoutils/go.mod
#	osmoutils/go.sum
#	x/epochs/go.mod
#	x/epochs/go.sum
#	x/ibc-hooks/go.mod
#	x/ibc-hooks/go.sum
mergify bot pushed a commit that referenced this pull request Apr 9, 2024
* bump sdk/iavl for async pruning

* update changelog

* update osmoutils iavl

* bump gomods

* Revert "bump gomods"

This reverts commit 85c29d0.

* iavl

* update go mods

* fix version

(cherry picked from commit 4b58243)

# Conflicts:
#	CHANGELOG.md
#	go.mod
#	go.sum
#	osmomath/go.mod
#	osmomath/go.sum
#	osmoutils/go.mod
#	osmoutils/go.sum
#	x/epochs/go.mod
#	x/epochs/go.sum
#	x/ibc-hooks/go.mod
#	x/ibc-hooks/go.sum
mergify bot pushed a commit that referenced this pull request Apr 9, 2024
* bump sdk/iavl for async pruning

* update changelog

* update osmoutils iavl

* bump gomods

* Revert "bump gomods"

This reverts commit 85c29d0.

* iavl

* update go mods

* fix version

(cherry picked from commit 4b58243)

# Conflicts:
#	CHANGELOG.md
#	go.sum
czarcas7ic added a commit that referenced this pull request Apr 9, 2024
* chore: bump sdk/iavl for async pruning (#7994)

* bump sdk/iavl for async pruning

* update changelog

* update osmoutils iavl

* bump gomods

* Revert "bump gomods"

This reverts commit 85c29d0.

* iavl

* update go mods

* fix version

(cherry picked from commit 4b58243)

# Conflicts:
#	CHANGELOG.md
#	go.mod
#	go.sum
#	osmomath/go.mod
#	osmomath/go.sum
#	osmoutils/go.mod
#	osmoutils/go.sum
#	x/epochs/go.mod
#	x/epochs/go.sum
#	x/ibc-hooks/go.mod
#	x/ibc-hooks/go.sum

* go back to original go mods

* v23 updates

* run script

* Update CHANGELOG.md

---------

Co-authored-by: Adam Tucker <adam@osmosis.team>
Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
czarcas7ic added a commit that referenced this pull request Apr 9, 2024
* chore: bump sdk/iavl for async pruning (#7994)

* bump sdk/iavl for async pruning

* update changelog

* update osmoutils iavl

* bump gomods

* Revert "bump gomods"

This reverts commit 85c29d0.

* iavl

* update go mods

* fix version

(cherry picked from commit 4b58243)

# Conflicts:
#	CHANGELOG.md
#	go.sum

* revert go mods

* add iavl replace

* run script

---------

Co-authored-by: Adam Tucker <adam@osmosis.team>
Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
czarcas7ic added a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v23.x backport patches to v23.x branch A:backport/v24.x backport patches to v24.x branch C:x/epochs V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants