-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump sdk/iavl for async pruning #7994
Conversation
Important Notice This PR modifies an in-repo Go module. It is one of:
The dependent Go modules, especially the root one, will have to be Please follow the instructions below:
Please let us know if you need any help. |
This reverts commit 85c29d0.
WalkthroughThe Osmosis project has taken a significant leap forward with the introduction of asynchronous pruning for its Inter-Blockchain Communication (IBC) application-specific data structure, IAVL, in versions v24.0.1 and v23.0.12-iavl-v1. This enhancement aims to improve the efficiency and performance of the data structure, making the system more robust and scalable. Alongside, the update encompasses various fixes and updates to bolster the stability and functionality of earlier versions. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚡
* bump sdk/iavl for async pruning * update changelog * update osmoutils iavl * bump gomods * Revert "bump gomods" This reverts commit 85c29d0. * iavl * update go mods * fix version (cherry picked from commit 4b58243) # Conflicts: # CHANGELOG.md # go.mod # go.sum # osmomath/go.mod # osmomath/go.sum # osmoutils/go.mod # osmoutils/go.sum # x/epochs/go.mod # x/epochs/go.sum # x/ibc-hooks/go.mod # x/ibc-hooks/go.sum
* bump sdk/iavl for async pruning * update changelog * update osmoutils iavl * bump gomods * Revert "bump gomods" This reverts commit 85c29d0. * iavl * update go mods * fix version (cherry picked from commit 4b58243) # Conflicts: # CHANGELOG.md # go.mod # go.sum # osmomath/go.mod # osmomath/go.sum # osmoutils/go.mod # osmoutils/go.sum # x/epochs/go.mod # x/epochs/go.sum # x/ibc-hooks/go.mod # x/ibc-hooks/go.sum
* chore: bump sdk/iavl for async pruning (#7994) * bump sdk/iavl for async pruning * update changelog * update osmoutils iavl * bump gomods * Revert "bump gomods" This reverts commit 85c29d0. * iavl * update go mods * fix version (cherry picked from commit 4b58243) # Conflicts: # CHANGELOG.md # go.mod # go.sum # osmomath/go.mod # osmomath/go.sum # osmoutils/go.mod # osmoutils/go.sum # x/epochs/go.mod # x/epochs/go.sum # x/ibc-hooks/go.mod # x/ibc-hooks/go.sum * go back to original go mods * v23 updates * run script * Update CHANGELOG.md --------- Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
* chore: bump sdk/iavl for async pruning (#7994) * bump sdk/iavl for async pruning * update changelog * update osmoutils iavl * bump gomods * Revert "bump gomods" This reverts commit 85c29d0. * iavl * update go mods * fix version (cherry picked from commit 4b58243) # Conflicts: # CHANGELOG.md # go.sum * revert go mods * add iavl replace * run script --------- Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
Closes: #XXX
What is the purpose of the change
We are noticing that some validators on IAVL v1 are missing blocks in the pruning interval, typically after epoch, due to larger blocks. This makes the pruning async, which should prevent these missed blocks from occurring.
Should be back ported to v23 IAVL v1 branch with tag v0.47.5-v23-osmo-9-iavl-v1
Testing and Verifying
Tested against osmosis mainet, and it unstuck a node that was pruning a large amount of blocks.