perf: Use SDK math v1.3.0 to speedup BigDec casts to/from Dec #7577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
requested review from
mattverse,
czarcas7ic,
p0mvn and
AlpinYukseloglu
as code owners
github-actions
bot
added
C:x/gamm
ValarDragon
added
V:state/compatible/backport
czarcas7ic
approved these changes
Feb 22, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
* Using sdk math v1.3.0, create BigDecFromDecMut, and use that wherever applicable * tryfix build * One more speedup * Add CeilMut * Use CeilMut (cherry picked from commit ef33c2c) # Conflicts: # go.mod # go.sum
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
* Using sdk math v1.3.0, create BigDecFromDecMut, and use that wherever applicable * tryfix build * One more speedup * Add CeilMut * Use CeilMut (cherry picked from commit ef33c2c) # Conflicts: # go.mod # go.sum
czarcas7ic
added a commit
that referenced
this pull request
Feb 22, 2024
#7577) (#7593) * perf: Use SDK math v1.3.0 to speedup BigDec casts to/from Dec (#7577) * Using sdk math v1.3.0, create BigDecFromDecMut, and use that wherever applicable * tryfix build * One more speedup * Add CeilMut * Use CeilMut (cherry picked from commit ef33c2c) # Conflicts: # go.mod # go.sum * tidy --------- Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
czarcas7ic
added a commit
that referenced
this pull request
Feb 22, 2024
#7577) (#7594) * perf: Use SDK math v1.3.0 to speedup BigDec casts to/from Dec (#7577) * Using sdk math v1.3.0, create BigDecFromDecMut, and use that wherever applicable * tryfix build * One more speedup * Add CeilMut * Use CeilMut (cherry picked from commit ef33c2c) # Conflicts: # go.mod # go.sum * tidy --------- Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7540
What is the purpose of the change
Lower number of heap calls that appear in CL logic / math. We are removing many heap allocations by being more mutative inside of calls to
Dec()and by introducing a new APIBigDecFromDecMut, and using that throughout the codebase.Testing and Verifying
This is covered by existing unit tests, and the state compatability check.
Where is the change documented?