Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only fetch uptime accumulators on Tick Crossings #7550

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

ValarDragon
Copy link
Member

Closes: #7536

What is the purpose of the change

Only fetch uptime accumulators on tick crossings

Testing and Verifying

This should be checked as long as we test uptime accumulators after swaps with:

  • 0 tick crossings
  • 1 tick crossing
  • many tick crossing

Documentation and Release Note

  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@p0mvn p0mvn self-assigned this Feb 19, 2024
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This make sense to me!

Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ValarDragon ValarDragon merged commit 7ba7edd into main Feb 21, 2024
1 check passed
@ValarDragon ValarDragon deleted the dev/only_fetch_uptime_accums_on_tick_cross branch February 21, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Make CL swaps only fetch uptime accumulators if there is a tick crossing
3 participants