[Uptime Incentives]: Create gov param for internal incentive & group gauge uptime #7418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
approved these changes
Feb 6, 2024
6 tasks
p0mvn
pushed a commit
that referenced
this pull request
Feb 8, 2024
…gauge uptime (#7418) * add internal uptime param to incentives module * fix init genesis test
p0mvn
pushed a commit
that referenced
this pull request
Feb 8, 2024
…gauge uptime (#7418) * add internal uptime param to incentives module * fix init genesis test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7370
What is the purpose of the change
This PR adds the
InternalUptimegov param to the incentives module. Please see issue for discussion on tradeoffs/implications.To simplify review process, this PR does not actually use the param in any core logic (that will be implemented and tested in #7371)
Testing and Verifying
Param not used in core logic, so e2e sanity check coverage should be sufficient. Did not add an upgrade handler test as it would be redundant with the 1-line implementation.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)