Support CL pools in TX Fee module #7267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattverse
requested review from
nicolaslara,
p0mvn and
AlpinYukseloglu
as code owners
czarcas7ic
reviewed
Jan 8, 2024
| @@ -65,7 +121,7 @@ func (s *KeeperTestSuite) TestUpgradeFeeTokenProposals() { | |||
| { | |||
| name: "proposal with non-existent pool", | |||
| feeToken: "foo", | |||
| poolId: 100000000000, | |||
| poolId: 10000000, | |||
There was a problem hiding this comment.
in pool manager keeper we only use 12 bytes for storing pool id, this requires 13 bytes & causes panic in tests thus needs to be lowered!
ValarDragon
approved these changes
Jan 8, 2024
ValarDragon
approved these changes
Jan 8, 2024
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: ##6783
What is the purpose of the change
Previously CL pools were not supported in tx fee module, as we were calculated sp via gamm keeper.
This PR changes it to use pool manager keeper instead for sp calculation
Testing and Verifying
This change added tests and can be verified as follows:
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)