feat: extended app hash logs #7253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarcas7ic
added
V:state/compatible/backport
mattverse
approved these changes
Jan 8, 2024
|
@mattverse after thinking about it, this app hash dump only helps with module app hashes. Last results hash do not cause module hashes to differ. That being said this is the first step, and on last result hashes we can eventually trigger a dump of last results endpoint |
PaddyMc
approved these changes
Jan 8, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
* app hash logs * changelog entry * Auto: update go.mod after push to adam/app-hash-logs that modified dependencies locally * add back replace * Auto: update go.mod after push to adam/app-hash-logs that modified dependencies locally * fix changelog * remove extra line --------- Co-authored-by: github-actions <github-actions@github.com> (cherry picked from commit ae036e8) # Conflicts: # CHANGELOG.md # go.mod # go.sum # osmomath/go.mod # osmomath/go.sum # osmoutils/go.mod # osmoutils/go.sum # x/epochs/go.mod # x/epochs/go.sum # x/ibc-hooks/go.mod # x/ibc-hooks/go.sum
czarcas7ic
added a commit
that referenced
this pull request
Jan 9, 2024
* feat: extended app hash logs (#7253) * app hash logs * changelog entry * Auto: update go.mod after push to adam/app-hash-logs that modified dependencies locally * add back replace * Auto: update go.mod after push to adam/app-hash-logs that modified dependencies locally * fix changelog * remove extra line --------- Co-authored-by: github-actions <github-actions@github.com> (cherry picked from commit ae036e8) # Conflicts: # CHANGELOG.md # go.mod # go.sum # osmomath/go.mod # osmomath/go.sum # osmoutils/go.mod # osmoutils/go.sum # x/epochs/go.mod # x/epochs/go.sum # x/ibc-hooks/go.mod # x/ibc-hooks/go.sum * fix merge conflicts --------- Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
When a node app hashes, we now print the hash of every module, which will further assist with debugging app hash problems.
Testing and Verifying
Tested against mainnet:
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)