Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove tx fee tracker #7237

Merged
merged 2 commits into from
Jan 3, 2024
Merged

chore: remove tx fee tracker #7237

merged 2 commits into from
Jan 3, 2024

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Jan 3, 2024

Closes: #XXX

What is the purpose of the change

This is part 1/2 in perf changes of and related to the proto rev tracker.

Part 1: Remove tx fee tracker completely
Part 2: Change the cyclic arb and taker fee trackers to not have to load every coin

@github-actions github-actions bot added C:x/txfees C:app-wiring Changes to the app folder labels Jan 3, 2024
@czarcas7ic czarcas7ic added the V:state/breaking State machine breaking PR label Jan 3, 2024
@czarcas7ic czarcas7ic marked this pull request as ready for review January 3, 2024 22:14
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ValarDragon ValarDragon merged commit b178758 into main Jan 3, 2024
1 check passed
@ValarDragon ValarDragon deleted the adam/remove-tx-fee-tracker branch January 3, 2024 23:27
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:app-wiring Changes to the app folder C:x/txfees V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants