Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x/gamm): remove duplicate query gamm pool subcommand #7120

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix(x/gamm): remove duplicate query gamm pool subcommand #7120

merged 1 commit into from
Dec 15, 2023

Conversation

levisyin
Copy link
Contributor

@levisyin levisyin commented Dec 15, 2023 •
edited
Loading

What is the purpose of the change

This pr fixed the duplicate subcommand osmosisd query gamm pool

image

Testing and Verifying

This change is already covered by existing tests, such as TestQueryTestSuite.

@github-actions github-actions bot added C:CLI C:x/gamm Changes, features and bugs related to the gamm module. labels Dec 15, 2023
@mattverse mattverse self-assigned this Dec 15, 2023
mattverse
mattverse approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks :)

@mattverse mattverse added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks A:no-changelog labels Dec 15, 2023
@mattverse mattverse merged commit 24271d7 into osmosis-labs:main Dec 15, 2023
1 check passed
@levisyin levisyin deleted the fix/duplicate-pool-cmd branch December 15, 2023 07:40
@github-actions github-actions bot mentioned this pull request Jan 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse mattverse approved these changes

@czarcas7ic czarcas7ic Awaiting requested review from czarcas7ic czarcas7ic is a code owner

@p0mvn p0mvn Awaiting requested review from p0mvn p0mvn is a code owner

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu is a code owner

Assignees

@mattverse mattverse

Labels
A:no-changelog C:CLI C:x/gamm Changes, features and bugs related to the gamm module. V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@levisyin @mattverse