Don't load all poolmanager params every swap #7074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
requested review from
p0mvn,
czarcas7ic,
mattverse and
AlpinYukseloglu
as code owners
czarcas7ic
reviewed
Dec 11, 2023
Comment on lines
+29
to
+30
| // TODO: This logic is actually wrong imo, where it can be valid to set an override over the default. | ||
| if takerFee.Equal(k.GetDefaultTakerFee(ctx)) { |
There was a problem hiding this comment.
I don't think I understand the comment. It is valid to override over the default. Instead of storing every taker fee for every pair, we assume every pair is default, and if we pull the value for that pair and its non default, its an override.
There was a problem hiding this comment.
This code comment is on SetDenomPairTakerFee, for when its being set.
Its saying if you override a taker fee to a value that is default, delete the state entry for this, and make it go to default.
However then if the default changes, this one changes as well, whereas you really wanted it to always stay at the old default value.
(This is independent of the main point of this PR)
czarcas7ic
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the IAVL v2 benchmarks, loading params for taker fees somewhat appears to be a 2% CPU consumption for the entire state machine. (Its a bit hard to reliably tell, since I don't have the binary for better views)
This PR anyways stops loading all of the params, and thereby should improve CPU / native speed, and will improve gas.
Validity of this change should be covered by default taker fee already being tested