Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(valset): withdraw rewards #6949

Merged
merged 2 commits into from
Nov 29, 2023
Merged

fix(valset): withdraw rewards #6949

merged 2 commits into from
Nov 29, 2023

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Nov 29, 2023

Closes: #XXX

What is the purpose of the change

Withdraw rewards in valset was utilizing the valset as the source of truth, while the UI displays all pending rewards. This changes the withdraw rewards method to consider all validators the user is delegated to, instead of strictly the validator set pref.

@czarcas7ic czarcas7ic added the V:state/breaking State machine breaking PR label Nov 29, 2023
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so painful. Lets do this.

The module is now marginally different from a live valset wrapper which should have just been a TS library. Or a non-upgradable contract + authz if we wanted such an architecture

@czarcas7ic czarcas7ic marked this pull request as ready for review November 29, 2023 22:55
@czarcas7ic czarcas7ic merged commit af05daa into main Nov 29, 2023
1 check passed
@czarcas7ic czarcas7ic deleted the adam/fix-withdraw-rewards branch November 29, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants