Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow protorev to receive tokens #6932

Closed
wants to merge 5 commits into from

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Nov 28, 2023

Closes: #XXX

What is the purpose of the change

wasmd has an extra check that prevents bank sends from working on module accounts. This PR unblocks the protorev account. Since the protorev module account never has many funds in it at any one time, the risk of something bad happening due to this change is capped at a fairly small amount.

Testing and Verifying

Testing to be done by skip

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@czarcas7ic czarcas7ic added the V:state/breaking State machine breaking PR label Nov 28, 2023
@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Nov 28, 2023
@czarcas7ic czarcas7ic closed this Nov 29, 2023
@czarcas7ic czarcas7ic reopened this Nov 29, 2023
Copy link
Contributor

@PaddyMc PaddyMc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the prints, but happy to merge this and backport to v21

@czarcas7ic czarcas7ic closed this Nov 30, 2023
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:app-wiring Changes to the app folder V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants