refactor: ListPoolsByDenom using pool.GetPoolDenoms directly #6914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levisyin
requested review from
czarcas7ic,
p0mvn,
mattverse and
AlpinYukseloglu
as code owners
pysel
added
the
V:state/compatible/no_backport
pysel
approved these changes
Nov 23, 2023
Just confused about the Tests/e2e CI running result, what I changed should't have an effect on CI IMO 😥 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to PR #6902, all pool type has implemented
GetPoolDenoms(sdk.Context) []string, we can use it to get pool denoms directly infunc ListPoolsByDenomTesting and Verifying
This change is already covered by existing tests, such as TestListPoolsByDenom.