Nicolas/1559 persist #6812
Merged
Nicolas/1559 persist #6812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
added a commit
that referenced
this pull request
Nov 3, 2023
* initial commit * More skeleton code * Is this good for testing? * sync * better comment * fix * Update * add cli * fix code * ensure it doesn't go below min * export eip struct * Update smth * update * moire prints * change target to 40M to see what happens * reparam + config * Nicolas/1559 persist (#6812) * persisting to disk * better prints after testing * add max base fee * cloning everywhere to be safe * chore: add unit tests to eip code * Add a recheck bound * Cfg + adjust constants * Make a GlobalMempool * Ok testing * remove log * lint * Apply @Pipello 's code suggestions * chore: add comments to eip-1559 code (#6818) * chore: add comments to eip-1559 code * Update x/txfees/keeper/mempool-1559/code.go Co-authored-by: Roman <roman@osmosis.team> * Update x/txfees/keeper/mempool-1559/code.go Co-authored-by: Roman <roman@osmosis.team> * chore: add logger, use const instead of var * chore: remove sleep in test --------- Co-authored-by: Roman <roman@osmosis.team> * add app.toml options for all vars * Revert "add app.toml options for all vars" This reverts commit 6fa54ba. --------- Co-authored-by: Adam Tucker <adamleetucker@outlook.com> Co-authored-by: Nicolas Lara <nicolaslara@gmail.com> Co-authored-by: PaddyMc <paddymchale@hotmail.com> Co-authored-by: Roman <roman@osmosis.team>
ValarDragon
added a commit
that referenced
this pull request
Nov 10, 2023
* initial commit * More skeleton code * Is this good for testing? * sync * better comment * fix * Update * add cli * fix code * ensure it doesn't go below min * export eip struct * Update smth * update * moire prints * change target to 40M to see what happens * reparam + config * Nicolas/1559 persist (#6812) * persisting to disk * better prints after testing * add max base fee * cloning everywhere to be safe * chore: add unit tests to eip code * Add a recheck bound * Cfg + adjust constants * Make a GlobalMempool * Ok testing * remove log * lint * Apply @Pipello 's code suggestions * chore: add comments to eip-1559 code (#6818) * chore: add comments to eip-1559 code * Update x/txfees/keeper/mempool-1559/code.go Co-authored-by: Roman <roman@osmosis.team> * Update x/txfees/keeper/mempool-1559/code.go Co-authored-by: Roman <roman@osmosis.team> * chore: add logger, use const instead of var * chore: remove sleep in test --------- Co-authored-by: Roman <roman@osmosis.team> * add app.toml options for all vars * Revert "add app.toml options for all vars" This reverts commit 6fa54ba. --------- Co-authored-by: Adam Tucker <adamleetucker@outlook.com> Co-authored-by: Nicolas Lara <nicolaslara@gmail.com> Co-authored-by: PaddyMc <paddymchale@hotmail.com> Co-authored-by: Roman <roman@osmosis.team>
ValarDragon
added a commit
that referenced
this pull request
Nov 10, 2023
* initial commit * More skeleton code * Is this good for testing? * sync * better comment * fix * Update * add cli * fix code * ensure it doesn't go below min * export eip struct * Update smth * update * moire prints * change target to 40M to see what happens * reparam + config * Nicolas/1559 persist (#6812) * persisting to disk * better prints after testing * add max base fee * cloning everywhere to be safe * chore: add unit tests to eip code * Add a recheck bound * Cfg + adjust constants * Make a GlobalMempool * Ok testing * remove log * lint * Apply @Pipello 's code suggestions * chore: add comments to eip-1559 code (#6818) * chore: add comments to eip-1559 code * Update x/txfees/keeper/mempool-1559/code.go Co-authored-by: Roman <roman@osmosis.team> * Update x/txfees/keeper/mempool-1559/code.go Co-authored-by: Roman <roman@osmosis.team> * chore: add logger, use const instead of var * chore: remove sleep in test --------- Co-authored-by: Roman <roman@osmosis.team> * add app.toml options for all vars * Revert "add app.toml options for all vars" This reverts commit 6fa54ba. --------- Co-authored-by: Adam Tucker <adamleetucker@outlook.com> Co-authored-by: Nicolas Lara <nicolaslara@gmail.com> Co-authored-by: PaddyMc <paddymchale@hotmail.com> Co-authored-by: Roman <roman@osmosis.team>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
(E.g.: This pull request improves documentation of area A by adding ....
Testing and Verifying
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)