Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error message for slippage bound when LPing #6788

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Oct 31, 2023

Closes: #XXX

What is the purpose of the change

When slippage bound is hit during LP, the error message is confusing. This PR improves it.

@p0mvn p0mvn added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v19.x backport patches to v19.x branch labels Oct 31, 2023
@p0mvn p0mvn marked this pull request as ready for review October 31, 2023 16:24
Copy link
Contributor

@AlpinYukseloglu AlpinYukseloglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p0mvn p0mvn added the A:backport/v20.x backport patches to v20.x branch label Oct 31, 2023
@p0mvn p0mvn merged commit e7517c2 into main Oct 31, 2023
1 check passed
@p0mvn p0mvn deleted the roman/slippage-bound-error-msg branch October 31, 2023 16:31
mergify bot pushed a commit that referenced this pull request Oct 31, 2023
* fix: improve error message for slippage bound when LPing

* updates

* changelog

(cherry picked from commit e7517c2)

# Conflicts:
#	CHANGELOG.md
mergify bot pushed a commit that referenced this pull request Oct 31, 2023
* fix: improve error message for slippage bound when LPing

* updates

* changelog

(cherry picked from commit e7517c2)

# Conflicts:
#	CHANGELOG.md
p0mvn added a commit that referenced this pull request Oct 31, 2023
) (#6790)

* fix: improve error message for slippage bound when LPing (#6788)

* fix: improve error message for slippage bound when LPing

* updates

* changelog

(cherry picked from commit e7517c2)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Roman <roman@osmosis.team>
@github-actions github-actions bot mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v19.x backport patches to v19.x branch A:backport/v20.x backport patches to v20.x branch C:x/concentrated-liquidity V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants