feat(poolmanager): v2 SpotPrice query with 36 decimals #6488
Conversation
github-actions
bot
added
C:CLI
C:app-wiring
p0mvn
changed the title
p0mvn
added
V:state/compatible/backport
p0mvn
requested review from
mattverse,
nicolaslara,
AlpinYukseloglu and
czarcas7ic
as code owners
|
|
||
| // SpotPriceRequest defines the gRPC request structure for a SpotPrice | ||
| // query. | ||
| message SpotPriceRequest { |
There was a problem hiding this comment.
shouldn't this also have a V2 suffix? to avoid confusing it to v1's version:
same goes for SpotPriceResponse
There was a problem hiding this comment.
on the second thought, I guess it is fine, since we call it by specifying a package name, which has v2 in it. still going to leave it here just in case
| @@ -1,4 +1,5 @@ | |||
| package grpc | |||
|
|
|||
There was a problem hiding this comment.
It probably doesn't matter but the package should be the first line, are we able to modify the template to do this for all of the below?
There was a problem hiding this comment.
Discussed offline and concluded that this is fine as long as no errors in the editor.
This stems from this line in the template:
#6488 (comment)
Didn't find a trivial way to fix and concluded that it is fine to keep as is since the change is only cosmetic
| package grpc | ||
| {{ $version := .VersionSuffix }} | ||
| package grpc{{$version}} |
* feat: make PoolModuleI CalculateSpotPrice API return BigDec * updates * clean up * updates * updates * feat(poolmaanger): v2 SpotPrice query with 36 decimals * changelog * clean up * Generated protofile changes * querygen updates * Update cmd/querygen/main.go --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Adam Tucker <adam@osmosis.team> (cherry picked from commit b1bfa20) # Conflicts: # CHANGELOG.md
… (#6561) Co-authored-by: roman <roman@osmosis.team>
Progress towards: #6064
What is the purpose of the change
This PR introduces a GRPC and CLI wrapper around the new BigDec API. Contrary to our existing queries, it does not truncate the final result and returns the full 36 decimals.
It includes some modifications to our query generation script to be able to properly generate v2 queries without conflicts.
Localosmosis Test
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)