Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set name, display and symbol of denom metadata in tokenfactory's CreateDenom #6344

Merged
merged 2 commits into from
Sep 12, 2023
Merged

fix: set name, display and symbol of denom metadata in tokenfactory's CreateDenom #6344

merged 2 commits into from
Sep 12, 2023

Conversation

madrezaz
Copy link
Contributor

@madrezaz madrezaz commented Sep 8, 2023

Closes: #6343

What is the purpose of the change

This pull request sets the name, symbol and display fields of a denom metadata when denom is created by the tokenfactory module.

Testing and Verifying

This change added tests and can be verified as follows:

  • Extended unit tests of genesis and createdenom to reflect reproducing the bug being fixed by this change

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@pysel pysel added the V:state/breaking State machine breaking PR label Sep 10, 2023
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! lgtm

@mattverse mattverse merged commit 66e720d into osmosis-labs:main Sep 12, 2023
1 check passed
@madrezaz madrezaz deleted the fix-tokenfactory-denom-metadata branch September 12, 2023 06:53
@github-actions github-actions bot mentioned this pull request Jan 15, 2024
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/tokenfactory V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bank module's exported genesis validation fails after denom creation in tokenfactory module
3 participants