Add fix for prop 597 code issue #6279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
devbot add changelog fix prop-572 introduced issue |
p0mvn
approved these changes
Sep 2, 2023
|
e2e is failing because init genesis is not updated accordingly. Started to update it in: #6280 However, I think we should merge as is and instead just test on a state-exported testnet |
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2023
* Add fix for prop 572 code issue * update changelog * Update CHANGELOG.md * basic upgrade unit test --------- Co-authored-by: devbot-wizard <141283918+devbot-wizard@users.noreply.github.com> Co-authored-by: Roman <roman@osmosis.team> (cherry picked from commit bd09d44) # Conflicts: # CHANGELOG.md # app/upgrades/v19/upgrades_test.go
ValarDragon
added a commit
that referenced
this pull request
Sep 2, 2023
This reverts commit bd09d44.
ValarDragon
added a commit
that referenced
this pull request
Sep 3, 2023
pysel
pushed a commit
that referenced
this pull request
Sep 4, 2023
* Add fix for prop 572 code issue * update changelog * Update CHANGELOG.md * basic upgrade unit test --------- Co-authored-by: devbot-wizard <141283918+devbot-wizard@users.noreply.github.com> Co-authored-by: Roman <roman@osmosis.team>
pysel
pushed a commit
that referenced
this pull request
Sep 4, 2023
pysel
pushed a commit
that referenced
this pull request
Sep 4, 2023
* Add fix for prop 572 code issue * update changelog * Update CHANGELOG.md * basic upgrade unit test --------- Co-authored-by: devbot-wizard <141283918+devbot-wizard@users.noreply.github.com> Co-authored-by: Roman <roman@osmosis.team>
pysel
pushed a commit
that referenced
this pull request
Sep 4, 2023
pysel
pushed a commit
that referenced
this pull request
Sep 4, 2023
* Add fix for prop 572 code issue * update changelog * Update CHANGELOG.md * basic upgrade unit test --------- Co-authored-by: devbot-wizard <141283918+devbot-wizard@users.noreply.github.com> Co-authored-by: Roman <roman@osmosis.team>
pysel
pushed a commit
that referenced
this pull request
Sep 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal 597 broke the cfmm-gamm pool links, due to the governance logic not behaving as expected (replacing a list of instead of fixing it)
Proposed for this to be included in the v19 upgrade due to urgency at hand.