Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle a TODO in synth lock (backport #6186) #6194

Merged
merged 1 commit into from
Aug 28, 2023
Merged

handle a TODO in synth lock (backport #6186) #6194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions x/lockup/keeper/synthetic_lock.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,11 @@ func (k Keeper) CreateSyntheticLockup(ctx sdk.Context, lockID uint64, synthDenom
// There is no relationship between unbonding and bonding synthetic lockup, it's managed separately
// A separate accumulation store is incremented with the synth denom.

// TODO: Next state break change !synthlock.IsNil -> found
synthLock, _, err := k.GetSyntheticLockupByUnderlyingLockId(ctx, lockID)
_, found, err := k.GetSyntheticLockupByUnderlyingLockId(ctx, lockID)
if err != nil {
return err
}
if !synthLock.IsNil() {
if found {
return types.ErrSyntheticLockupAlreadyExists
}

Expand All @@ -136,7 +135,7 @@ func (k Keeper) CreateSyntheticLockup(ctx sdk.Context, lockID uint64, synthDenom
}

// set synthetic lockup object
synthLock = types.SyntheticLock{
synthLock := types.SyntheticLock{
UnderlyingLockId: lockID,
SynthDenom: synthDenom,
EndTime: endTime,
Expand Down