Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CLI autocomplete to makefile #6012

Merged
merged 8 commits into from
Aug 11, 2023
Merged

Conversation

czarcas7ic
Copy link
Member

Closes: #XXX

What is the purpose of the change

This PR adds a install-with-autocomplete Makefile command, which adds the autocomplete to your profile. If using bash, a separate package must be installed in order to get it to work, which this does as well.

I considered just adding this to the install command, but I don't think we should be adding things to people's profiles as the default method. Although I do think the majority of people will want to use this method in place of the usual install.

Testing and Verifying

This has been tested on:

  1. Mac using zsh
  2. Mac using bash
  3. Linux using bash

And all have worked!

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@czarcas7ic czarcas7ic added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label Aug 10, 2023
@czarcas7ic
Copy link
Member Author

@devbot-wizard help

@devbot-wizard
Copy link
Collaborator

Hi! I'm DevBot, a bot that helps with common tasks in the development process. Commands:

  • devbot fix: Fix basic errors in the PR. (e.g. imports, changelog conflicts, go mod conflicts)
  • devbot merge base: Merge the base branch into the PR branch.
  • devbot add changelog [misc/feat/bug/api/sec] [message]: Add a changelog entry to the PR. (e.g. devbot add changelog feat Added a new feature)
    • If message is blank, defaults to PR title.
  • devbot re-pr: Re-PR the PR, useful for external contributors where we have no edit perms.

@czarcas7ic czarcas7ic changed the title chore: add autocomplete to makefile chore: add CLI autocomplete to makefile Aug 10, 2023
@czarcas7ic czarcas7ic marked this pull request as ready for review August 10, 2023 01:50
@czarcas7ic czarcas7ic requested a review from a team as a code owner August 10, 2023 01:50
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@czarcas7ic czarcas7ic merged commit 708ee2e into main Aug 11, 2023
1 check passed
@czarcas7ic czarcas7ic deleted the adam/autocomplete-make-file branch August 11, 2023 22:09
p0mvn pushed a commit that referenced this pull request Aug 29, 2023
* add autocomplete to make file

* make bash the shell for makefile in place of sh

* changes

* add line

* remove parent shell print

* proper spacing

* update changelog

* update changelog

---------

Co-authored-by: devbot-wizard <141283918+devbot-wizard@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:build V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants