[Chore] Remove SF partial migration from balancer to CL

[stackman27]

Closes: #XXX

What is the purpose of the change

Remove Partial Migration

Testing and Verifying

Remove Partial Migration Tests

Documentation and Release Note

• Does this pull request introduce a new feature or user-facing behavior changes?
• Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

• Specification (x/{module}/README.md)
• Osmosis documentation site
• Code comments?
• N/A

[ValarDragon]

luv2delete code

[p0mvn]

We might also want to remove this:

• osmosis/x/superfluid/keeper/migrate.go

  Lines 327 to 332 in d70e4e1

  	// Otherwise, we must split the lock and force unlock the partial shares to migrate.
  	// This breaks and deletes associated synthetic locks.
  	err = k.lk.PartialForceUnlock(ctx, *lock, sdk.NewCoins(sharesToMigrate))
  	if err != nil {
  	return sdk.Coins{}, err
  	}

[p0mvn]

LGTM

[czarcas7ic]

@stackman27 Can you modify this

osmosis/x/superfluid/keeper/migrate.go

Lines 318 to 333 in d70e4e1

	// Finish unlocking directly for locked or unlocking locks
	if sharesToMigrate.Equal(gammSharesInLock) {
	// If migrating the entire lock, force unlock.
	// This breaks and deletes associated synthetic locks.
	err = k.lk.ForceUnlock(ctx, *lock)
	if err != nil {
	return sdk.Coins{}, err
	}
	} else {
	// Otherwise, we must split the lock and force unlock the partial shares to migrate.
	// This breaks and deletes associated synthetic locks.
	err = k.lk.PartialForceUnlock(ctx, *lock, sdk.NewCoins(sharesToMigrate))
	if err != nil {
	return sdk.Coins{}, err
	}
	}

To just check if they are equal? Other than that it looks good to me

[stackman27]

@stackman27 Can you modify this

osmosis/x/superfluid/keeper/migrate.go

Lines 318 to 333 in d70e4e1

	// Finish unlocking directly for locked or unlocking locks
	if sharesToMigrate.Equal(gammSharesInLock) {
	// If migrating the entire lock, force unlock.
	// This breaks and deletes associated synthetic locks.
	err = k.lk.ForceUnlock(ctx, *lock)
	if err != nil {
	return sdk.Coins{}, err
	}
	} else {
	// Otherwise, we must split the lock and force unlock the partial shares to migrate.
	// This breaks and deletes associated synthetic locks.
	err = k.lk.PartialForceUnlock(ctx, *lock, sdk.NewCoins(sharesToMigrate))
	if err != nil {
	return sdk.Coins{}, err
	}
	}

To just check if they are equal? Other than that it looks good to me

added check around this! lmk what you think

[czarcas7ic]

I think we should just take in the lock ID and not the sharesToMigrate, and instead just pull the shares directly in this method. This API only made sense when shares to migrate was chooseable which it no longer is

[stackman27]

one of the thought process i had was since we only call the migration functions using RouteLockedBalancerToConcentratedMigration and MigrateUnlockedPositionFromBalancerToConcentrated does allow partial migration, i wanted to keep sharesToMigrate. For all the private migration functions like migrateSuperfluidBondedBalancerToConcentrated we can just default it to the entire lock coins which we do in validateSharesToMigrateUnlockAndExitBalancerPool

[czarcas7ic]

Ah I see yeah, that makes sense, thanks!

[czarcas7ic]

Re-reviewed and its LGTM, merging, thanks!