Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: import cycle resolution with migration records #5596

Merged
merged 17 commits into from
Jun 22, 2023
Merged

chore: import cycle resolution with migration records #5596

merged 17 commits into from
Jun 22, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Jun 21, 2023

Closes: #XXX

What is the purpose of the change

Discussed with Adam and agreed to add this import cycle resolution PR if it can be achieved under 20 mins.

The solution is to generate migration protos in a separate package so that the import cycles are removed.

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@github-actions github-actions bot added C:app-wiring Changes to the app folder C:CLI C:x/concentrated-liquidity C:x/gamm Changes, features and bugs related to the gamm module. C:x/pool-incentives C:x/superfluid labels Jun 21, 2023
@p0mvn p0mvn mentioned this pull request Jun 21, 2023
Merged
6 tasks
p0mvn and others added 2 commits June 21, 2023 13:36
@p0mvn @czarcas7ic
Update x/pool-incentives/keeper/grpc_query.go
fc686f6 
Co-authored-by: Adam Tucker <adam@osmosis.team>
@p0mvn @czarcas7ic
Update x/pool-incentives/types/expected_keepers.go
45056ee 
Co-authored-by: Adam Tucker <adam@osmosis.team>
czarcas7ic
czarcas7ic approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks for getting this done

@p0mvn p0mvn marked this pull request as ready for review June 21, 2023 18:55
Base automatically changed from adam/direct-indirect-incentivized-pools to main June 22, 2023 01:54
@p0mvn p0mvn added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks A:no-changelog V:state/breaking State machine breaking PR and removed V:state/compatible/no_backport State machine compatible PR, depends on prior breaks labels Jun 22, 2023
@p0mvn p0mvn merged commit 0fbeed2 into main Jun 22, 2023
@p0mvn p0mvn deleted the roman/import-migration branch June 22, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

@stackman27 stackman27 Awaiting requested review from stackman27

Assignees
No one assigned
Labels
A:no-changelog C:app-wiring Changes to the app folder C:CLI C:x/concentrated-liquidity C:x/gamm Changes, features and bugs related to the gamm module. C:x/pool-incentives C:x/superfluid V:state/breaking State machine breaking PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @czarcas7ic