Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: duplicate price for multiple ticks #5173
fix: duplicate price for multiple ticks #5173
Changes from 6 commits
db88fa2
17574ad
02b0341
766283b
c3b5d5d
9e688e0
b5f5383
296271f
a08aa03
ca34bb8
9fb6fcd
f7509a8
5c82ca3
f8756cd
a9d0c31
c3a7ac5
53c59cc
058fcc4
b966b05
17f5bde
46b9ef0
814ea89
a74fbd6
b5923f0
3ace477
f6d640e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to handle this for the initial tick?
osmosis/x/concentrated-liquidity/lp.go
Lines 421 to 424 in c673324
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, only because the PriceToTickRoundDown function always returns the canonical tick. The only thing that needs to be changed is user provided ticks