-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error handling when exiting 100% of pool shares #4806
Conversation
@@ -19,7 +19,7 @@ import ( | |||
const ( | |||
nonPostiveSharesAmountErrFormat = "shares amount must be positive, was %s" | |||
nonPostiveTokenAmountErrFormat = "token amount must be positive, was %s" | |||
sharesLargerThanMaxErrFormat = "%s resulted shares is larger than the max amount of %s" | |||
sharesLargerThanMaxErrFormat = "resulted shares %s should be lower than the max amount of %s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is solving the problem presented in the issue. The problem seems to be that incorrect values are being formatted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we could just subtract one from the max amount, how it was proposed here?
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
Closing for staleness |
Closes: #3427