Better error handling when exiting 100% of pool shares #4806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C:x/gamm
pysel
added
V:state/compatible/backport
p0mvn
requested changes
Mar 31, 2023
| @@ -19,7 +19,7 @@ import ( | |||
| const ( | |||
| nonPostiveSharesAmountErrFormat = "shares amount must be positive, was %s" | |||
| nonPostiveTokenAmountErrFormat = "token amount must be positive, was %s" | |||
| sharesLargerThanMaxErrFormat = "%s resulted shares is larger than the max amount of %s" | |||
| sharesLargerThanMaxErrFormat = "resulted shares %s should be lower than the max amount of %s" | |||
There was a problem hiding this comment.
I don't think this is solving the problem presented in the issue. The problem seems to be that incorrect values are being formatted
There was a problem hiding this comment.
So we could just subtract one from the max amount, how it was proposed here?
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
|
Closing for staleness |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3427