Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify pool query in pool manager, deprecate x/gamm, remove from CL module #4658

Merged
merged 3 commits into from
Mar 17, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Mar 17, 2023

Closes: #XXX

What is the purpose of the change

This PR unifies the Pool query for balancer, stableswap and CL pools in the x/poolmanager module. It removes the corresponding query from the CL module as x/poolmanager should be the only correct entry point.

In x/gamm, it deprecates the corresponding query to maintain backward compatibility. The logic calls in the x/poolmanager keeper that now routes calls.

Simlar is done for the CLI.

Brief Changelog

  • implement Pool query in x/poolmanager
  • refactor x/gamm to call the pool manager's keeper
  • remove the query and CLI from `x/concentrated-liquidity

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? not applicable

@p0mvn p0mvn changed the title refactor: unify pool query in pool manager, deprecate x/gamm, remove … refactor: unify pool query in pool manager, deprecate x/gamm, remove from CL module Mar 17, 2023
@github-actions github-actions bot added C:CLI C:x/concentrated-liquidity C:x/gamm Changes, features and bugs related to the gamm module. C:x/poolmanager labels Mar 17, 2023
@p0mvn p0mvn added the V:state/breaking State machine breaking PR label Mar 17, 2023
@p0mvn p0mvn marked this pull request as ready for review March 17, 2023 19:51
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job getting this out so fast. I think we are good to merge to unblock frontend. All logic LGTM

tests/cl-go-client/main.go Outdated Show resolved Hide resolved
Co-authored-by: Adam Tucker <adam@osmosis.team>
@p0mvn p0mvn merged commit 4b7fe40 into main Mar 17, 2023
@p0mvn p0mvn deleted the roman/poolmanager-pool branch March 17, 2023 20:15
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:x/concentrated-liquidity C:x/gamm Changes, features and bugs related to the gamm module. C:x/poolmanager V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants