Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set proper wasm bytecode size #4388

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Set proper wasm bytecode size #4388

merged 2 commits into from
Feb 22, 2023

Conversation

nicolaslara
Copy link
Contributor

@nicolaslara nicolaslara commented Feb 22, 2023 •
edited
Loading

#4174 changed the maximum bytecode size to 2MB. I didn't realize at the time that the max size for wasm upload via proposals was already set to 3MB, so that change actually "decreesed" the maximum allowed bytecode size for mainnet (since most contracts are uploaded via proposals) and only increased it for the testnet and allowed uploaders.

What is the purpose of the change

This change sets the wasm bytecode size to 3MB for both proposals and allowed wallets.

Brief Changelog

All stored contract codes have a maximum of 3MB now

Testing and Verifying

all tests pass

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes /)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes /)
  • How is the feature or change documented? (not applicable)

@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Feb 22, 2023
@nicolaslara nicolaslara added V:state/compatible/backport State machine compatible PR, should be backported V:state/breaking State machine breaking PR A:backport/v15.x backport patches to v15.x branch and removed V:state/compatible/backport State machine compatible PR, should be backported labels Feb 22, 2023
@p0mvn p0mvn merged commit ad8f3d1 into main Feb 22, 2023
@p0mvn p0mvn deleted the nicolas/better-size-limits branch February 22, 2023 14:12
mergify bot pushed a commit that referenced this pull request Feb 22, 2023
@nicolaslara @mergify
Set proper wasm bytecode size (#4388)
9a45b83 
* new wasm size

* add changelog

(cherry picked from commit ad8f3d1)
@mergify mergify bot mentioned this pull request Feb 22, 2023
Merged
@ValarDragon
Copy link
Member

Oh interesting, didn't realize they had a distinction between gov upload size and main tx upload size

@nicolaslara
Copy link
Contributor Author

me neither 😅 . Noticed it when I was looking into how small XCS needs to be to be uploaded before the upgrade. Turns out... we can just upload it now if it's via a proposal

nicolaslara added a commit that referenced this pull request Feb 22, 2023
@mergify @nicolaslara
Set proper wasm bytecode size (#4388) (#4391)
48e074d 
* new wasm size

* add changelog

(cherry picked from commit ad8f3d1)

Co-authored-by: Nicolas Lara <nicolaslara@gmail.com>
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Closed
@github-actions github-actions bot mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0mvn p0mvn p0mvn approved these changes

Assignees
No one assigned
Labels
A:backport/v15.x backport patches to v15.x branch C:app-wiring Changes to the app folder V:state/breaking State machine breaking PR
Projects
Osmosis Chain Development
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolaslara @ValarDragon @p0mvn