fix: don't increment code ID in e2e before running #3635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarcas7ic
added
V:state/compatible/backport
p0mvn
approved these changes
Dec 6, 2022
Co-authored-by: Roman <roman@osmosis.team>
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
* dont increment code ID * Update tests/e2e/e2e_test.go Co-authored-by: Roman <roman@osmosis.team> Co-authored-by: Roman <roman@osmosis.team> (cherry picked from commit 08a9aa1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Roman had to disable the IBC rate limiter test due to an unknown bug. This fixes that bug and re-enables that e2e test.
The reason we incremented this before is because the contract was uploaded in the upgrade handler, and this was a prior workaround to test this within e2e itself.
Brief Changelog