[ValSet-Pref] Add RedelegateValidatorSet message
#3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackman27
commented
Dec 2, 2022
| // A redelegation object is created every time a redelegation occurs. To prevent "redelegation hopping" redelegations may not occur under the situation that: | ||
| // 1. the (re)delegator already has another immature redelegation in progress with a destination to a validator (let's call it Validator X) | ||
| // 2. the (re)delegator is attempting to create a new redelegation where the source validator for this new redelegation is Validator X | ||
| func (k Keeper) PreformRedelegation(ctx sdk.Context, delegator sdk.AccAddress, existingSet types.ValidatorSetPreferences, newSet []types.ValidatorPreference) error { |
There was a problem hiding this comment.
Notes for reviewers: Best way to follow with this algorithm would be to check README.MD where i have made sure the pseudocode comments matches with the code comments
There was a problem hiding this comment.
The algo looks correct to me, but I think in a follow-up PR we can simplify / break up the logic a bit.
e.g. make getExistingValset -> getExistingDelegations its own function
czarcas7ic
requested changes
Dec 4, 2022
czarcas7ic
approved these changes
Dec 9, 2022
stackman27
force-pushed
the
sis/valset-pref-ReDelMsg
branch
from
fb4bad2
to
a5aa909
Compare
czarcas7ic
approved these changes
Dec 15, 2022
ValarDragon
approved these changes
Dec 16, 2022
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of : #2579
What is the purpose of the change
Introduce Redelegation logic to validator set preference. User now will be able to redelegate from a specific validator to a new set of validator. We are doing this by executing 2 messages;
Brief Changelog
n/a
Testing and Verifying
Added msg_server_test.go for TestRedelegateValidatorSet
example output:
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)