-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ValSet-Pref] Setup tx and query and added GetCmdValSetPref
and NewSetValSetCmd
#3498
Conversation
GetCmdValSetPref
query GetCmdValSetPref
and NewSetValSetCmd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
1a0ea7d
to
5203018
Compare
@stackman27 can you check this again? Seems like go test is failing now |
5203018
to
1f1041c
Compare
1f1041c
to
f7067a6
Compare
f7067a6
to
efa9921
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, aside from the rate-limter.wasm deletion (and check generated code failing, presumably proto or querygen)
You can bring back rate limiter wasm by doing git checkout main tests/e2e/scripts/rate_limiter./wasm
Part of #2579
What is the purpose of the change
Setup query for ValSet-Pref module and add
GetCmdValSetPref
query.GetCmdValSetPref
queries the preference set of a specific delegator. I will add the rest of the queries as we continue merging the new messages.NewSetValSetCmd
Creates a new validator set for the delegator with valOperAddress and weight. For Example:osmosisd tx valset-pref set-valset osmo1... osmovaloper1abc...,osmovaloper1def... 0.56,0.44
Brief Changelog
n/a
Testing and Verifying
added query_test to test
GetCmdValSetPref
, tx messageNewSetValSetCmd
untestedDocumentation and Release Note
Unreleased
section inCHANGELOG.md
? (yes / no)x/<module>/spec/
) / Osmosis docs repo / not documented)