Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ValSet-Pref] Setup tx and query and added GetCmdValSetPref and NewSetValSetCmd #3498

Merged
merged 5 commits into from
Dec 3, 2022

Conversation

stackman27
Copy link
Contributor

@stackman27 stackman27 commented Nov 23, 2022

Part of #2579

What is the purpose of the change

Setup query for ValSet-Pref module and add GetCmdValSetPref query. GetCmdValSetPref queries the preference set of a specific delegator. I will add the rest of the queries as we continue merging the new messages.

NewSetValSetCmd Creates a new validator set for the delegator with valOperAddress and weight. For Example:
osmosisd tx valset-pref set-valset osmo1... osmovaloper1abc...,osmovaloper1def... 0.56,0.44

Brief Changelog

n/a

Testing and Verifying

added query_test to test GetCmdValSetPref, tx message NewSetValSetCmd untested

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@stackman27 stackman27 requested a review from a team November 23, 2022 08:15
@github-actions github-actions bot added C:app-wiring Changes to the app folder C:CLI labels Nov 23, 2022
@stackman27 stackman27 added the V:state/compatible/backport State machine compatible PR, should be backported label Nov 23, 2022
@stackman27 stackman27 changed the title [ValSet-Pref] Setup query and add GetCmdValSetPref query [ValSet-Pref] Setup tx and query and added GetCmdValSetPref and NewSetValSetCmd Nov 24, 2022
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

x/valset-pref/client/cli/query.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the C:x/twap Changes to the twap module label Nov 27, 2022
@czarcas7ic
Copy link
Member

@stackman27 can you check this again? Seems like go test is failing now

@ValarDragon ValarDragon added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks and removed V:state/compatible/backport State machine compatible PR, should be backported labels Nov 28, 2022
x/twap/api.go Outdated Show resolved Hide resolved
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from the rate-limter.wasm deletion (and check generated code failing, presumably proto or querygen)

You can bring back rate limiter wasm by doing git checkout main tests/e2e/scripts/rate_limiter./wasm

@ValarDragon ValarDragon merged commit 04a17ac into main Dec 3, 2022
@ValarDragon ValarDragon deleted the valset-cli branch December 3, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:app-wiring Changes to the app folder C:CLI V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants