Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow 100 percent exit from pools #3428

Closed
wants to merge 3 commits into from
Closed

allow 100 percent exit from pools #3428

wants to merge 3 commits into from

Conversation

joe-bowman
Copy link

@joe-bowman joe-bowman commented Nov 17, 2022 •
edited
Loading

Closes: #3427

What is the purpose of the change

This pull request allows the last user with liquidity in a pool to exit the pool with 100% of their shares.

Brief Changelog

  • Allow 100% exit from pool by using GT instead of GTE.

Testing and Verifying

This change added tests and can be verified as follows:

  • Added unit test that validates 100% exit from pool

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? not documented

@joe-bowman joe-bowman requested a review from a team November 17, 2022 12:48
@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Nov 17, 2022
@ValarDragon
Copy link
Member

closing per discussion in issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C:x/gamm Changes, features and bugs related to the gamm module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message when trying to Exit 100% of a pool
2 participants
@joe-bowman @ValarDragon