Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x/gamm][stableswap]: Increase max post-scaled amount to 10^34 #3290

Merged
merged 5 commits into from
Nov 7, 2022
Merged

[x/gamm][stableswap]: Increase max post-scaled amount to 10^34 #3290

merged 5 commits into from
Nov 7, 2022

Conversation

AlpinYukseloglu
Copy link
Contributor

Closes: #3289

What is the purpose of the change

This PR increases the max post-scaled asset amount to 10^34 and ensures this bound is properly tested.

Brief Changelog

  • Increase max post-scaled asset amount to 10^34
  • Update validation logic and tests

Testing and Verifying

  • All relevant tests in amm_test.go and msgs_test.go are updated and pass

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (no)
  • How is the feature or change documented? (not documented)

@AlpinYukseloglu AlpinYukseloglu requested a review from a team November 7, 2022 21:16
@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Nov 7, 2022
@AlpinYukseloglu AlpinYukseloglu added C:stableswap V:state/breaking State machine breaking PR labels Nov 7, 2022
@AlpinYukseloglu AlpinYukseloglu mentioned this pull request Nov 7, 2022
Closed
34 tasks
ValarDragon
ValarDragon reviewed Nov 7, 2022
View reviewed changes
x/gamm/pool-models/stableswap/amm_test.go Outdated
Comment on lines 877 to 879
sdk.NewInt64Coin("foo", 10),
sdk.NewInt64Coin("bar", 10),
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why doesn't 1 work here?

ValarDragon
ValarDragon approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from 1->10 changes

@ValarDragon ValarDragon merged commit d9c8942 into main Nov 7, 2022
@ValarDragon ValarDragon deleted the alpo/stableswap-increase-max-scaled branch November 7, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

Assignees
No one assigned
Labels
C:stableswap C:x/gamm Changes, features and bugs related to the gamm module. V:state/breaking State machine breaking PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[x/gamm][stableswap]: Increase max post-scaled amount to 10^34
2 participants
@AlpinYukseloglu @ValarDragon