IBC: rate limit native tokens on all channels #3229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9ffdc37.
…las/ibc-rate-limit/new-denom-logic
…nto nicolas/ibc-rate-limit/channel-any
nicolaslara
added
the
V:state/compatible/no_backport
ValarDragon
reviewed
Nov 4, 2022
|
This PR can probably be closed in favor of #3234. The only point of having them separately was to be able to develop and review it in steps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #3219 to unify all quotas for native denoms into one: the "any" channel.
When sending or receiving a native denom, the contract is not queried for the specific ibc channel used, but instead the catch-all "any", which means transfers through any channel will increase or reduce the quota.
As an example, if someone sends 1 osmo to juno and 1 osmo to the akash, then the used quota for osmo will be 2. If the max quota setup for the channel "any" was 2, then no other osmo sends will be allowed.
Right now only the any channel is checked. This could be extended to check both "any" and the channel id. That way we could add different limits to each channel beyond the global limit. Since we're planning on moving some of this logic to the contract I don't think it makes sense to do it on this PR, but we can discuss it in case we want it later.