Stop returning error logs + stack trace when out of gas in ApplyFuncIfNoErr #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theres an out of gas in ApplyFuncIfNoErr
ValarDragon
added
A:backport/v8.x
alexanderbez
approved these changes
Sep 30, 2022
p0mvn
approved these changes
Oct 1, 2022
|
Is there a specific reason we are not backporting to v10x? |
mattverse
pushed a commit
that referenced
this pull request
Oct 13, 2022
…fNoErr (backport #2914) (#2917) * Stop returning error logs + stack trace when out of gas in ApplyFuncIfNoErr (#2914) * Stop returning error logs + stack trace when theres an out of gas in ApplyFuncIfNoErr * Fix import * Changelog (cherry picked from commit 1ec8658) # Conflicts: # CHANGELOG.md # osmoutils/cache_ctx.go * add gitiginore and changelog * merge conflict fix Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Dev Ojha <dojha@berkeley.edu>
mattverse
added a commit
that referenced
this pull request
Oct 13, 2022
…fNoErr (backport #2914) (#2918) * Stop returning error logs + stack trace when out of gas in ApplyFuncIfNoErr (#2914) * Stop returning error logs + stack trace when theres an out of gas in ApplyFuncIfNoErr * Fix import * Changelog (cherry picked from commit 1ec8658) # Conflicts: # CHANGELOG.md * Fix merge conflict Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: mattverse <mattpark1028@gmail.com>
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backportable component of #2487
What is the purpose of the change
Stop panic logs such as https://gist.github.com/jhernandezb/55b70c570a23dd2cc709b630a04acc16 in node operator logs
Brief Changelog
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes