Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dependencies for merged commit of the cosmos-sdk fork #2421

Merged
merged 3 commits into from
Aug 27, 2022

Conversation

nicolaslara
Copy link
Contributor

This replaces #2308 with the correct dependency commit

What is the purpose of the change

Point the cosmos sdk dependency to the correct commit

Brief Changelog

Point the cosmos sdk dependency to the correct commit

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (/ no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (/ no)
  • How is the feature or change documented? (not applicable )

@nicolaslara
Copy link
Contributor Author

hmm, apparently this sdk fork commit is also causing issues (mostly on simtypes and e2e): osmosis-labs/cosmos-sdk@059c959. CC @czarcas7ic

@czarcas7ic
Copy link
Member

@nicolaslara I utilized the commit prior to that (934d0d94bef8b62e656c6a142223ecd12fa9a4c9) and it passes CI (#2419)

I would say it has to be the most recent PR to the SDK fork then

@nicolaslara
Copy link
Contributor Author

ahh but this makes sense then. It's basically that #2419 needs to be merged before this PR.

@czarcas7ic
Copy link
Member

@nicolaslara Just a heads up, the PR you were waiting for has been merged!

@nicolaslara
Copy link
Contributor Author

great! I'll update this so it can be merged

@ValarDragon ValarDragon merged commit cb583e1 into main Aug 27, 2022
@ValarDragon ValarDragon deleted the nicolas/merged-supply-offset-dependency branch August 27, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants