Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ci): improve update paths job with per-branch names and check out non-main branch #2400

Merged
merged 1 commit into from
Aug 13, 2022
Merged

refactor(ci): improve update paths job with per-branch names and check out non-main branch #2400

merged 1 commit into from
Aug 13, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Aug 13, 2022

…

Closes: #XXX

What is the purpose of the change

Currently, there are issues with running the job on non-main branches that were discovered after trying to use it more:

  • one is PR name clash due to duplicate PR names (assuming we update main and old branch at ones)
  • checking out code on main by default prevents from opening the PRs on old branches

This change fixes the above problems

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@p0mvn p0mvn added the A:backport/v11.x backport patches to v11.x branch label Aug 13, 2022
@github-actions github-actions bot added the T:CI label Aug 13, 2022
@p0mvn p0mvn marked this pull request as ready for review August 13, 2022 02:52
@p0mvn p0mvn requested a review from a team August 13, 2022 02:52
@ValarDragon ValarDragon merged commit a1dc694 into main Aug 13, 2022
@ValarDragon ValarDragon deleted the roman/improve-ci-job branch August 13, 2022 04:51
mergify bot pushed a commit that referenced this pull request Aug 13, 2022
@p0mvn @mergify
refactor(ci): improve update paths job with per-branch names and chec…
1d177f7 
…k out non-main branch (#2400)

(cherry picked from commit a1dc694)
@mergify mergify bot mentioned this pull request Aug 13, 2022
Merged
p0mvn added a commit that referenced this pull request Aug 15, 2022
@mergify @p0mvn
refactor(ci): improve update paths job with per-branch names and chec…
8ddc855 
…k out non-main branch (#2400) (#2402)

(cherry picked from commit a1dc694)

Co-authored-by: Roman <roman@osmosis.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

Assignees
No one assigned
Labels
A:backport/v11.x backport patches to v11.x branch T:CI
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @ValarDragon