Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: enable gosimple #1957

Merged
merged 1 commit into from
Jul 4, 2022
Merged

lint: enable gosimple #1957

merged 1 commit into from
Jul 4, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Jul 4, 2022

Closes: #XXX

What is the purpose of the change

Follow-up to: #1897

Enable gosimple - subset of staticcheck binary

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@github-actions github-actions bot added the T:CI label Jul 4, 2022
@p0mvn
Copy link
Member Author

p0mvn commented Jul 4, 2022

Not sure how valuable this is since it caught only one problem. I'm still down to try it but if lint times become an issue this should be the first candidate to be removed

@p0mvn p0mvn marked this pull request as ready for review July 4, 2022 17:25
@p0mvn p0mvn requested a review from a team July 4, 2022 17:25
@ValarDragon ValarDragon merged commit cc82980 into main Jul 4, 2022
@ValarDragon ValarDragon deleted the roman/lint-gosimple branch July 4, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants