Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deadcode linter #1934

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Add deadcode linter #1934

merged 1 commit into from
Jul 1, 2022

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Jul 1, 2022 •
edited
Loading

Cref: #1897

What is the purpose of the change

Adds the deadcode linter! Roman had a great idea to do this!

Brief Changelog

  • Add deadcode linter. I added a nolint to anything I didn't have certainty around whether it may still be used shortly.

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@ValarDragon ValarDragon requested a review from a team July 1, 2022 03:52
@github-actions github-actions bot added C:x/gamm Changes, features and bugs related to the gamm module. C:x/lockup C:x/mint C:x/tokenfactory T:CI labels Jul 1, 2022
@AlpinYukseloglu
Copy link
Contributor

awesome!

mattverse
mattverse approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh just what we needed 🌮

@mattverse mattverse merged commit c0573d1 into main Jul 1, 2022
@mattverse mattverse deleted the dev/add_deadcode_linter branch July 1, 2022 05:24
@p0mvn p0mvn mentioned this pull request Jul 1, 2022
Merged
@ValarDragon ValarDragon added the A:backport/v10.x backport patches to v10.x branch label Jul 18, 2022
mergify bot pushed a commit that referenced this pull request Jul 18, 2022
@ValarDragon @mergify
Add deadcode linter (#1934)
819e817 
(cherry picked from commit c0573d1)

# Conflicts:
#	tests/e2e/containers/config.go
#	x/gamm/pool-models/balancer/pool.go
#	x/mint/simulation/genesis.go
@mergify mergify bot mentioned this pull request Jul 18, 2022
Closed
@ValarDragon ValarDragon removed the A:backport/v10.x backport patches to v10.x branch label Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse mattverse approved these changes

Assignees
No one assigned
Labels
C:x/gamm Changes, features and bugs related to the gamm module. C:x/lockup C:x/mint C:x/tokenfactory T:CI
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValarDragon @AlpinYukseloglu @mattverse