bug: tx flags for txfees update prop #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarcas7ic
added
A:backport/v9.x
|
@czarcas7ic Was it not working before and just not used? Just curious how this was never caught |
Codecov Report
@@ Coverage Diff @@
## main #1546 +/- ##
=======================================
Coverage 19.46% 19.46%
=======================================
Files 241 241
Lines 32183 32183
=======================================
Hits 6264 6264
Misses 24767 24767
Partials 1152 1152 Continue to review full report at Codecov.
|
|
My guess is all the current submissions were done via lcd @p0mvn |
p0mvn
approved these changes
May 19, 2022
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2022
Can't submit txfees prop without fees flags (cherry picked from commit ae19a4c)
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2022
Can't submit txfees prop without fees flags (cherry picked from commit ae19a4c)
czarcas7ic
added a commit
that referenced
this pull request
May 19, 2022
czarcas7ic
added a commit
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't submit txfees prop without fees flags