-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Stableswap #1523
Disable Stableswap #1523
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1523 +/- ##
==========================================
+ Coverage 19.50% 19.54% +0.03%
==========================================
Files 231 235 +4
Lines 31527 31598 +71
==========================================
+ Hits 6150 6176 +26
- Misses 24251 24293 +42
- Partials 1126 1129 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. If stableswap was its own module, you wouldn't have to comment anything out -- you just exclude it from the modules list in app.go.
cc @ValarDragon
Closes: #1503
What is the purpose of the change
The upcoming V9 upgrade should be including the gamm generalization, but not stable swap implementations.
This PR removes(comments out) stable swap inplementation and existing stableswap calls, which was to my surprise only present in
msg_sever.go
andmodule.go
.Brief Changelog
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? nox/<module>/spec/
) / Osmosis docs repo / not documented)