-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to go1.18 (backport #1177) #1194
Conversation
* update to go1.18 * Update CHANGELOG.md (cherry picked from commit eed3294) # Conflicts: # .github/workflows/test.yml
RIP the linter changed across the upgrade, so a bunch of lints to fix |
Codecov Report
@@ Coverage Diff @@
## v7.x #1194 +/- ##
=======================================
Coverage 20.86% 20.86%
=======================================
Files 199 199
Lines 25416 25416
=======================================
Hits 5303 5303
Misses 19150 19150
Partials 963 963 Continue to review full report at Codecov.
|
Yikes, there's a handful of linting errors. I presume linters were tweaked on |
It was version incompatibility issues between the golangci-lint version and go1.18, updating the golangci-lint to match the version in main fixes this! |
This is an automatic backport of pull request #1177 done by Mergify.
Cherry-pick of eed3294 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com