Add Superfluid Params Query #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1063 +/- ##
==========================================
- Coverage 20.66% 20.64% -0.02%
==========================================
Files 193 193
Lines 25251 25270 +19
==========================================
Hits 5218 5218
- Misses 19077 19096 +19
Partials 956 956
Continue to review full report at Codecov.
|
ValarDragon
approved these changes
Mar 9, 2022
mergify bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
* sf params * query proto change * added generated proto * keeper updates (cherry picked from commit 9f64276)
ValarDragon
pushed a commit
that referenced
this pull request
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified ParamsRequest/Response to QueryParamsRequest/Response to keep with format.
Modified respective protos, tested on client node with valid response
minimum_risk_factor: "0.500000000000000000"We still might need to rename this param as discussed previously (as per Path's suggestion on discord), but at least we can display on CLI now.
For contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer