Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add partial unlocking flag for cli #1049

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Conversation

mconcat
Copy link
Collaborator

@mconcat mconcat commented Mar 7, 2022

Closes: #998

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

Codecov Report

Merging #1049 (151990d) into main (bff6f64) will increase coverage by 0.01%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1049      +/-   ##
==========================================
+ Coverage   20.60%   20.61%   +0.01%     
==========================================
  Files         193      193              
  Lines       25237    25249      +12     
==========================================
+ Hits         5199     5205       +6     
- Misses      19084    19088       +4     
- Partials      954      956       +2     
Impacted Files Coverage Δ
x/lockup/client/cli/tx.go 59.75% <40.00%> (-3.26%) ⬇️
x/lockup/client/cli/flags.go 66.66% <100.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff6f64...151990d. Read the comment docs.

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ValarDragon ValarDragon added the A:backport/v7.x Do not use. backport patches to v7.x branch label Mar 7, 2022
@ValarDragon ValarDragon merged commit 493feb8 into main Mar 7, 2022
@ValarDragon ValarDragon deleted the mconcat/partial-unlock-cli branch March 7, 2022 18:52
mergify bot pushed a commit that referenced this pull request Mar 7, 2022
ValarDragon pushed a commit that referenced this pull request Mar 7, 2022
(cherry picked from commit 493feb8)

Co-authored-by: mconcat <monoidconcat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v7.x Do not use. backport patches to v7.x branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add CLI method for partial unlock
3 participants