Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unbond and stake serialization issues #6330

Closed
Tracked by #5864
p0mvn opened this issue Sep 6, 2023 · 4 comments
Closed
Tracked by #5864

fix: unbond and stake serialization issues #6330

p0mvn opened this issue Sep 6, 2023 · 4 comments
Labels
C:x/superfluid T:bug 🐛 Something isn't working

Comments

@p0mvn
Copy link
Member

p0mvn commented Sep 6, 2023

Background

There are serialization issues with unbond and stake message.

Empty string for the validator address doesn't get properly serialized and causes signature mismatch issues.

The same problem for zero lock id

Context: https://osmosis-network.slack.com/archives/C03JT90769K/p1694032456473589?thread_ts=1693917419.462069&cid=C03JT90769K

Suggested Design

  • placeholder for empty validator address as "none"
  • change lock id from 0 to -1 to signify unlocked

Acceptance Criteria

  • changes applied
  • unit tests updated
  • confirmation from @jonator that FE is unblocked receieved
@p0mvn p0mvn added T:bug 🐛 Something isn't working C:x/superfluid labels Sep 6, 2023
@jonator
Copy link
Member

jonator commented Sep 7, 2023

While this is not a perfect solution, it would save us time until telescope can handle nullable values, and is a proven solution when looking back to the "migrate to full range position" message (using lockId -1 instead of 0)

@czarcas7ic
Copy link
Member

@jonator, @mattverse should be reaching out to you WRT fixing the serialization on the frontend side, since there was agreement we should do what we can to not solve this chain side

@mattverse
Copy link
Member

Left comment in frontend channel

@ValarDragon
Copy link
Member

Closing this for now, since its FE libs serialization error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/superfluid T:bug 🐛 Something isn't working
Projects
Archived in project
Development

No branches or pull requests

5 participants