Add int overflow panic catching test

osmosis-labs · Jun 6, 2023 · ed66bce · ed66bce
1 parent 22d528e
commit ed66bce
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/x/protorev/keeper/hooks.go b/x/protorev/keeper/hooks.go
@@ -1,6 +1,8 @@
 package keeper
 
 import (
+	"errors"
+
 	sdk "github.com/cosmos/cosmos-sdk/types"
 
 	gammtypes "github.com/osmosis-labs/osmosis/v16/x/gamm/types"
@@ -115,7 +117,7 @@ func (k Keeper) GetComparablePoolLiquidity(ctx sdk.Context, poolId uint64) (comp
 	defer func() {
 		if r := recover(); r != nil {
 			comparableLiquidity = sdk.Int{}
-			err = sdk.ErrIntOverflowAbci
+			err = errors.New("Int overflow in GetComparablePoolLiquidity")
 		}
 	}()
 

diff --git a/x/protorev/keeper/hooks_test.go b/x/protorev/keeper/hooks_test.go
@@ -527,6 +527,18 @@ func (s *KeeperTestSuite) TestGetComparablePoolLiquidity() {
 			},
 			expectPass: true,
 		},
+		{
+			name: "Catch overflow error on liquidity multiplication",
+			param: param{
+				executePoolCreation: func() uint64 {
+					return s.PrepareBalancerPoolWithCoins(
+						sdk.NewCoin("uosmo", sdk.Int(sdk.NewUintFromString("999999999999999999999999999999999999999"))),
+						sdk.NewCoin("juno", sdk.Int(sdk.NewUintFromString("999999999999999999999999999999999999999"))))
+				},
+				expectedComparableLiquidity: sdk.Int{},
+			},
+			expectPass: false,
+		},
 	}
 
 	for _, tc := range tests {
@@ -542,6 +554,9 @@ func (s *KeeperTestSuite) TestGetComparablePoolLiquidity() {
 			if tc.expectPass {
 				s.Require().NoError(err)
 				s.Require().Equal(tc.param.expectedComparableLiquidity, comparableLiquidity)
+			} else {
+				s.Require().Error(err)
+				s.Require().Equal(tc.param.expectedComparableLiquidity, comparableLiquidity)
 			}
 		})
 	}