feat(pool-incentives): allow zero-weight distribution records (#563)

osmosis-labs · Oct 30, 2021 · 954bb5c · 954bb5c
1 parent db509c4
commit 954bb5c
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -41,6 +41,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+* Allow zero-weight pool-incentive distribution records
 * Fix bug in incentives epoch distribution events, used to use raw address, now uses bech32 addr
 * Update peer ID of statesync-enabled node run by notional
 * Created a pull request template

diff --git a/x/pool-incentives/types/gov_test.go b/x/pool-incentives/types/gov_test.go
@@ -47,6 +47,18 @@ func TestUpdatePoolIncentivesProposalMarshalUnmarshal(t *testing.T) {
 				},
 			},
 		},
+		{ // zero-weight record
+			proposal: &types.UpdatePoolIncentivesProposal{
+				Title:       "title",
+				Description: "proposal to update pool incentives",
+				Records: []types.DistrRecord{
+					{
+						GaugeId: 1,
+						Weight:  sdk.NewInt(0),
+					},
+				},
+			},
+		},
 		{ // two records
 			proposal: &types.UpdatePoolIncentivesProposal{
 				Title:       "title",

diff --git a/x/pool-incentives/types/record.go b/x/pool-incentives/types/record.go
@@ -1,7 +1,7 @@
 package types
 
 func (r DistrRecord) ValidateBasic() error {
-	if !r.Weight.IsPositive() {
+	if r.Weight.IsNegative() {
 		return ErrDistrRecordNotPositiveWeight
 	}
 	return nil

diff --git a/x/pool-incentives/types/record_test.go b/x/pool-incentives/types/record_test.go
@@ -16,7 +16,7 @@ func TestDistrRecord(t *testing.T) {
 		Weight:  sdk.NewInt(0),
 	}
 
-	require.Error(t, zeroWeight.ValidateBasic())
+	require.NoError(t, zeroWeight.ValidateBasic())
 
 	negativeWeight := types.DistrRecord{
 		GaugeId: 1,