Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OTEL wiring in grpcserver interceptor (DataDog POC) (backport #612) #619

Merged
merged 8 commits into from
Jul 23, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 23, 2024

This PR wires up OTEL tracing in gprcserver interceptor, allowing tracing requests that originate from external services.

I had to bump up go as 1.20 did not support some of the otel grpc dependencies.

This has led to bumping up go versions of a lot of the CI stuff.

Tested.


This is an automatic backport of pull request #612 done by Mergify.

@mergify mergify bot added the conflicts label Jul 23, 2024
Copy link
Author

mergify bot commented Jul 23, 2024

Cherry-pick of 5c3a933 has failed:

On branch mergify/bp/osmo/v0.50.x/pr-612
Your branch is up to date with 'origin/osmo/v0.50.x'.

You are currently cherry-picking commit 5c3a9339e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .github/workflows/test.yml
	modified:   server/grpc/server.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/lint.yml
	both modified:   .golangci.yml
	both modified:   baseapp/grpcserver.go
	both modified:   go.mod
	both modified:   go.sum
	both modified:   simapp/go.mod
	both modified:   simapp/go.sum
	both modified:   tests/go.mod
	both modified:   tests/go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

@mergify[bot] your pull request is missing a changelog!

@p0mvn p0mvn force-pushed the mergify/bp/osmo/v0.50.x/pr-612 branch from 795abb7 to 45fbb72 Compare July 23, 2024 04:26
@p0mvn p0mvn changed the title OTEL wiring in grpcserver interceptor (DataDog POC) (backport #612) feat: OTEL wiring in grpcserver interceptor (DataDog POC) (backport #612) Jul 23, 2024
@p0mvn p0mvn merged commit b5b1d9f into osmo/v0.50.x Jul 23, 2024
44 checks passed
@p0mvn p0mvn deleted the mergify/bp/osmo/v0.50.x/pr-612 branch July 23, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant