Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: bring back the cliff vesting command (#111) #271

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

ValarDragon
Copy link
Member

What is the purpose of the change

Bring back cliff vesting command from PR #111 , this was a very useful UX flow for folks doing cliff vesting on-chain.

Brief Changelog

  • Restore the CliffVesting CLI command

Testing and Verifying

This change is identical to what we had before.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? Code comment

Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK!

@czarcas7ic czarcas7ic changed the title Bring back the cliff vesting command (#111) feat!: bring back the cliff vesting command (#111) Jun 23, 2022
Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 2 suggestions. Why was the command originally removed?

x/auth/vesting/client/cli/tx.go Outdated Show resolved Hide resolved
x/auth/vesting/client/cli/tx.go Show resolved Hide resolved
@ValarDragon
Copy link
Member Author

It got removed due to branch mismanagement, not intentional

@ValarDragon ValarDragon merged commit bf5b163 into osmosis-main Jun 23, 2022
@ValarDragon ValarDragon deleted the dev/make_cliff_vesting_easier branch June 23, 2022 19:28
mergify bot pushed a commit that referenced this pull request Jun 23, 2022
* Bring back the cliff vesting command #111

* Wrap error

(cherry picked from commit bf5b163)

# Conflicts:
#	x/auth/vesting/client/cli/tx.go
ValarDragon added a commit that referenced this pull request Jun 23, 2022
)

* feat!: bring back the cliff vesting command (#111) (#271)

* Bring back the cliff vesting command #111

* Wrap error

(cherry picked from commit bf5b163)

# Conflicts:
#	x/auth/vesting/client/cli/tx.go

* fix conflict

* Fix merge conflict

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Dev Ojha <dojha@berkeley.edu>
czarcas7ic pushed a commit that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants