forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: bring back the cliff vesting command (#111) #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czarcas7ic
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK!
czarcas7ic
changed the title
Bring back the cliff vesting command (#111)
feat!: bring back the cliff vesting command (#111)
Jun 23, 2022
p0mvn
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 2 suggestions. Why was the command originally removed?
It got removed due to branch mismanagement, not intentional |
ValarDragon
added a commit
that referenced
this pull request
Jun 23, 2022
) * feat!: bring back the cliff vesting command (#111) (#271) * Bring back the cliff vesting command #111 * Wrap error (cherry picked from commit bf5b163) # Conflicts: # x/auth/vesting/client/cli/tx.go * fix conflict * Fix merge conflict Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Dev Ojha <dojha@berkeley.edu>
ValarDragon
added a commit
that referenced
this pull request
Jan 3, 2024
czarcas7ic
pushed a commit
that referenced
this pull request
May 9, 2024
czarcas7ic
pushed a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Bring back cliff vesting command from PR #111 , this was a very useful UX flow for folks doing cliff vesting on-chain.
Brief Changelog
Testing and Verifying
This change is identical to what we had before.
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? no