Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: app version stored in multistore, state sync snapshots share app version (testing on v10) #264

Closed
wants to merge 12 commits into from
Closed

refactor: app version stored in multistore, state sync snapshots share app version (testing on v10) #264

wants to merge 12 commits into from

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Jun 15, 2022 •
edited
Loading

Closes: #XXX

What is the purpose of the change

TBD: State sync fix

Brief Changelog

(for example:)

  • The metadata is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • Daemons retrieve the RPC data from the blob cache

Testing and Verifying

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added unit test that validates ...
  • Added integration tests for end-to-end deployment with ...
  • Extended integration test for ...
  • Manually verified the change by ...

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@p0mvn p0mvn changed the base branch from osmosis-main to v0.45.0x-osmo-v7 June 15, 2022 15:40
p0mvn
p0mvn commented Jun 15, 2022
View reviewed changes
baseapp/abci.go Show resolved Hide resolved
p0mvn
p0mvn commented Jun 15, 2022
View reviewed changes
store/rootmulti/store.go Outdated Show resolved Hide resolved
p0mvn
p0mvn commented Jun 15, 2022
View reviewed changes
store/rootmulti/store.go Outdated Show resolved Hide resolved
p0mvn
p0mvn commented Jun 15, 2022
View reviewed changes
baseapp/baseapp.go Outdated Show resolved Hide resolved
p0mvn
p0mvn commented Jun 15, 2022
View reviewed changes
baseapp/abci.go Show resolved Hide resolved
@p0mvn p0mvn mentioned this pull request Jun 15, 2022
Closed
@p0mvn p0mvn changed the title refactor: app version stored in multistore, state sync snapshots share app version refactor: app version stored in multistore, state sync snapshots share app version (testing on v10) Jun 15, 2022
@p0mvn
Copy link
Member Author

p0mvn commented Jun 16, 2022

closing in favor of #265

@p0mvn p0mvn closed this Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez Awaiting requested review from alexanderbez alexanderbez will be requested when the pull request is marked ready for review alexanderbez is a code owner

Assignees
No one assigned
Labels
C:Simulations C:x/params C:x/upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@p0mvn